So, while Marco's problem started with the project's shoddy documentation and API, his actual code criticism focuses on issues that are apparently superficial. He hasn't discovered a substantive bug or architectural weakness in the snippet above. Instead, what matters to him are simple virtues like consistency, style, and readability. Marco is saying, in fact, that the OpenSSL code sucks because it lacks superficial beauty. I couldn't agree with this position more.
Именно так. А за goto в кусок кода, закрытый if(0), я бы дополнительно еще бил линейкой по рукам.
Там есть много ссылок на интересные куски кода - хорошие и плохие - рекомендую посмотреть. Во время перехода по ссылке на код procmail рекомендую сидеть и ничего не пить, во избежание травм.